provider/google: allow session affinity for compute_backend_service #10387
Conversation
There was a problem hiding this comment.
Hey @bpineau, thanks for the PR! This looks great to me, the only thing I'd request is adding a TestStep to your test that exercises updating the session affinity, just so we can be sure that all the parts of this keep working over time.
bpineau
force-pushed
the
google_session_affinity
branch
from
f4a6fb9 to
c52a589
Compare
Google's Backend Services gives users control over the session affinity modes.
Let's allow Terraform users to leverage this option.
We don't change the default value ("NONE", as provided by Google).
bpineau
force-pushed
the
google_session_affinity
branch
from
c52a589 to
f2a3c5d
Compare
|
Hi @paddyforan , thanks for the feedback and the test idea ! |
|
This looks great, thanks so much for adding that, @bpineau. Great addition to our GCP support! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Google's Backend Services gives users control over the session affinity modes.
Let's allow Terraform users to leverage this option.
We don't change the default value ("NONE"), as provided by Google.
This is commited against master, but merges and works fine in main-0.7 too;).