provider/aws: Add "no_device" support to ephemeral block devices

[timonwong]

Fixes #8455, #5390

This add a new no_device attribute to ephemeral_block_device block,
which allows users omit ephemeral devices from AMI's predefined block
device mappings, which is useful for EBS-only instance types.

[kwilczynski]

@timonwong hi there! Thank you!

Would there be a way to guard against someone not specifying either virtual_name or no_device? Given that both are optional now, thus if someone omits both, then the default would be false for no_device resulting in an empty string being used coming from virtual_name. Could that cause a problem?

[timonwong]

@kwilczynski I just added a check which requires virtual_name if no_device is falsy.

[kwilczynski]

@timonwong hi there! Looks good! Anything else to add or left to do?

[timonwong]

@kwilczynski I think it's Ok to remove WIP tag now :)

[stack72]

Hi @timonwong

(and @kwilczynski!)

Thanks to you both for the work here - this LGTM! :)

Paul

[tinder-jlee]

Doesn't it need to also support no_device for device blocks definition in aws_launch_configuration?
https://www.terraform.io/docs/providers/aws/r/launch_configuration.html#block-devices

The definition is not the same as for aws_instance:
https://www.terraform.io/docs/providers/aws/r/instance.html#block-devices

which i believe should be the same.

[apparentlymart]

Hi @tinder-jlee!

This issue is from a long time ago, prior to the AWS provider development moving to its own repository. In order for it to be seen by that provider's maintainer team, please feel free to open an issue for this over in that repository.

[tinder-jlee]

@apparentlymart gotcha. i'll create an issue there. thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.