Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Add 'aws_iam_account_alias' data source #10804

Merged
merged 2 commits into from
Dec 18, 2016
Merged

provider/aws: Add 'aws_iam_account_alias' data source #10804

merged 2 commits into from
Dec 18, 2016

Conversation

ewbankkit
Copy link
Contributor

Returns the IAM account alias for the AWS account associated with the provider connection.
I though about adding this functionality to the aws_caller_identity data source but since it makes a call to the IAM service there could be an issue with permissions (e.g. not authorized to call that service or operation) and didn't want to break backwards compatibility.
Acceptance tests:

make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSIamAccountAlias_'

@stack72
Copy link
Contributor

stack72 commented Dec 18, 2016

Hi @ewbankkit

Thanks for the work here - I resolved the merge conflicts and the tests pass as expected:

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSIamAccountAlias_basic'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/12/18 14:11:21 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSIamAccountAlias_basic -timeout 120m
=== RUN   TestAccAWSIamAccountAlias_basic
--- PASS: TestAccAWSIamAccountAlias_basic (13.79s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	13.845s

Paul

@stack72 stack72 merged commit ca18312 into hashicorp:master Dec 18, 2016
@ewbankkit ewbankkit deleted the aws_account_alias-data-source branch January 7, 2017 12:38
@ghost
Copy link

ghost commented Apr 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants