Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/google: Use node_version during google_container_cluster creation #10817

Merged
merged 1 commit into from
Dec 18, 2016
Merged

provider/google: Use node_version during google_container_cluster creation #10817

merged 1 commit into from
Dec 18, 2016

Conversation

cblecker
Copy link
Contributor

@cblecker cblecker commented Dec 18, 2016

It appears that the node_version was never hooked into the google_container_cluster creation step. This step maps the node_version field to the proper API field so that a specific version can be requested at cluster provision time.

$ make testacc TEST=./builtin/providers/google TESTARGS='-run=TestAccContainerCluster_withVersion'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/12/17 22:24:48 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/google -v -run=TestAccContainerCluster_withVersion -timeout 120m
=== RUN   TestAccContainerCluster_withVersion
--- PASS: TestAccContainerCluster_withVersion (389.43s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/google	389.444s

@cblecker cblecker changed the title Use node_version during google_container_cluster creation provider/google: Use node_version during google_container_cluster creation Dec 18, 2016
@stack72
Copy link
Contributor

stack72 commented Dec 18, 2016

Hi @cblecker

This LGTM! Thanks for noticing (and fixing!) this

% make testacc TEST=./builtin/providers/google TESTARGS='-run=TestAccContainerCluster_'                                     130 ↵
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/12/18 13:21:11 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/google -v -run=TestAccContainerCluster_ -timeout 120m
=== RUN   TestAccContainerCluster_basic
--- PASS: TestAccContainerCluster_basic (307.58s)
=== RUN   TestAccContainerCluster_withVersion
--- PASS: TestAccContainerCluster_withVersion (398.18s)
=== RUN   TestAccContainerCluster_withNodeConfig
--- PASS: TestAccContainerCluster_withNodeConfig (317.38s)
=== RUN   TestAccContainerCluster_withNodeConfigScopeAlias
--- PASS: TestAccContainerCluster_withNodeConfigScopeAlias (307.46s)

@stack72 stack72 merged commit b7faae4 into hashicorp:master Dec 18, 2016
@cblecker cblecker deleted the gke-initial-cluster-version branch December 18, 2016 15:42
@ghost
Copy link

ghost commented Apr 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants