-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provider/aws: Add 'aws_vpc_peering_connection' data source #10913
provider/aws: Add 'aws_vpc_peering_connection' data source #10913
Conversation
@@ -450,7 +451,7 @@ func init() { | |||
" no session name is passed to the AssumeRole call.", | |||
|
|||
"assume_role_external_id": "The external ID to use when assuming the role. If omitted," + | |||
" no external ID is passed to the AssumeRole call.", | |||
" no external ID is passed to t he AssumeRole call.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this modification is a mistake :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. I'll revert it.
|
||
req := &ec2.DescribeVpcPeeringConnectionsInput{} | ||
|
||
if id := d.Get("id"); id != "" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
d.GetOk("id") wouldn't be better ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK.
@ewbankkit hi there! Thank you for this. Would you consider adding support for the requester and accepter blocks to expose configuration that is available there, what do you think? |
Read: dataSourceAwsVpcPeeringConnectionRead, | ||
|
||
Schema: map[string]*schema.Schema{ | ||
"id": &schema.Schema{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From Go 1.7 onwards type is derived, therefore there is no need to add schema.Schema
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK.
@kwilczynski Yes, I'll support for the |
…ata source output attributes.
LGTM! Thanks for the work here @ewbankkit and the review @kwilczynski I agree on not supporting IPV6 just now
|
…#10913) * Add 'aws_vpc_peering_connection' data source. * Changes after code review. * Add 'accepter' and 'requester' blocks to aws_vpc_peering_connection data source output attributes.
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Provides details about a specific VPC peering connection.
I tried to keep the semantics of the attributes the same as for the
aws_vpc_peering_connection
resource.Acceptance test: