Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Fixed the need of sending S3 Replication StorageClass when not set #10921

Merged
merged 1 commit into from
Dec 27, 2016

Conversation

Ninir
Copy link
Contributor

@Ninir Ninir commented Dec 24, 2016

Description

Fixes #10909

Acceptance test

$ make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSS3Bucket_ReplicationWithoutStorageClass'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/12/24 11:43:54 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSS3Bucket_ReplicationWithoutStorageClass -timeout 120m
=== RUN   TestAccAWSS3Bucket_ReplicationWithoutStorageClass
--- PASS: TestAccAWSS3Bucket_ReplicationWithoutStorageClass (80.27s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	80.302s

Merry Christmas all! 😄 🎄 🎅

@jen20
Copy link
Contributor

jen20 commented Dec 27, 2016

Hi @Ninir! This looks like a valid change and test, but could you give a brief description of what the issue is if this patch is not applied? Thanks!

@jen20
Copy link
Contributor

jen20 commented Dec 27, 2016

Actually I just found the bug report in #10909 - disregard my previous comment. Thanks!

@jen20 jen20 merged commit 63dbfc2 into hashicorp:master Dec 27, 2016
@Ninir Ninir deleted the s3_replication_storage_class branch February 24, 2017 14:48
@ghost
Copy link

ghost commented Apr 16, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3 Replication Configuration returns 400 error but thinks it has applied anyway
2 participants