provider/openstack: LoadBalancer Security Groups #11074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the ability to specify security groups on a loadbalancer resource.
stack72
reviewed
Jan 9, 2017
| @@ -126,6 +134,25 @@ func resourceLoadBalancerV2Create(d *schema.ResourceData, meta interface{}) erro | |||
| return err | |||
| } | |||
|
|
|||
| // Once the loadbalancer has been created, apply any requested security groups | |||
| // to the port that was created behind the scenes. | |||
| if lb.VipPortID != "" { | |||
There was a problem hiding this comment.
Is it worth letting the Create func call the Update func here? That way you wouldn't need to duplicate the code too much
Will that introduce any more risk?
P.
There was a problem hiding this comment.
That's an interesting idea! I'll try it out.
Moving common security group code into a dedicated function.
|
@stack72 I wasn't able to successfully call the Update function, but I was able to break the logic out into a dedicated function. |
|
LGTM! :) |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the ability to specify security groups on a loadbalancer
resource.
Fixes #11066