provider/aws: Add Support for aws_cloudwatch_metric_alarm extended statistic #11193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stack72
added
dependencies
grubernaut
suggested changes
Jan 13, 2017
| if v, ok := d.GetOk("extended_statistic"); ok { | ||
| params.ExtendedStatistic = aws.String(v.(string)) | ||
| } | ||
|
|
There was a problem hiding this comment.
If one or the other has to be set, should probably check for that here, and verify that at least one but not both have been set.
| @@ -67,7 +67,7 @@ The following arguments are supported: | |||
| * `namespace` - (Required) The namespace for the alarm's associated metric. See docs for the [list of namespaces](https://docs.aws.amazon.com/AmazonCloudWatch/latest/DeveloperGuide/aws-namespaces.html). | |||
| See docs for [supported metrics](https://docs.aws.amazon.com/AmazonCloudWatch/latest/DeveloperGuide/CW_Support_For_AWS.html). | |||
| * `period` - (Required) The period in seconds over which the specified `statistic` is applied. | |||
| * `statistic` - (Required) The statistic to apply to the alarm's associated metric. | |||
| * `statistic` - (Optional) The statistic to apply to the alarm's associated metric. | |||
There was a problem hiding this comment.
Add in documentation here specifying that you can only have one of statistic or extended_statistic
statistic Fixes: #11189 This introduces a new parameter and makes an existing parameter from `required` to `optional` as both cannot be specified together ``` % make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSCloudWatchMetricAlarm_' 2 ↵ ✹ ✭ ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) 2017/01/13 11:25:24 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSCloudWatchMetricAlarm_ -timeout 120m === RUN TestAccAWSCloudWatchMetricAlarm_importBasic --- PASS: TestAccAWSCloudWatchMetricAlarm_importBasic (19.80s) === RUN TestAccAWSCloudWatchMetricAlarm_basic --- PASS: TestAccAWSCloudWatchMetricAlarm_basic (20.42s) === RUN TestAccAWSCloudWatchMetricAlarm_extendedStatistic --- PASS: TestAccAWSCloudWatchMetricAlarm_extendedStatistic (18.92s) PASS ```
stack72
force-pushed
the
b-aws-cloudmetricalarm-extendedstatistic
branch
from
420b7b4 to
43c8366
Compare
|
Nice review @grubernaut :) Added the changes and an extra test to show the failure if you don't specify either config value |
grubernaut
approved these changes
Jan 13, 2017
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #11189
This introduces a new parameter and makes an existing parameter from
requiredtooptionalas both cannot be specified together