provider/google: Add support for session_affinity to google_compute_region_backend_service

[cblecker]

$ make testacc TEST=./builtin/providers/google TESTARGS='-run=TestAccComputeRegionBackendService_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/01/16 13:44:45 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/google -v -run=TestAccComputeRegionBackendService_ -timeout 120m
=== RUN   TestAccComputeRegionBackendService_basic
--- PASS: TestAccComputeRegionBackendService_basic (67.05s)
=== RUN   TestAccComputeRegionBackendService_withBackend
--- PASS: TestAccComputeRegionBackendService_withBackend (105.11s)
=== RUN   TestAccComputeRegionBackendService_withBackendAndUpdate
--- PASS: TestAccComputeRegionBackendService_withBackendAndUpdate (131.22s)
=== RUN   TestAccComputeRegionBackendService_withSessionAffinity
--- PASS: TestAccComputeRegionBackendService_withSessionAffinity (66.38s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/google	369.775s

Fixes #11199.

[cblecker]

cc: @evandbrown @danawillow FYI :)

[danawillow]

Can you also check here that the new region backend service not just exists but has the correct session affinity?

[cblecker]

Fixed.

[cblecker]

Result of modified acceptance test:

$ make testacc TEST=./builtin/providers/google TESTARGS='-run=TestAccComputeRegionBackendService_withSessionAffinity'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/01/17 16:28:16 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/google -v -run=TestAccComputeRegionBackendService_withSessionAffinity -timeout 120m
=== RUN   TestAccComputeRegionBackendService_withSessionAffinity
--- PASS: TestAccComputeRegionBackendService_withSessionAffinity (44.65s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/google	44.668s

[zopanix]

Is it possible to have an ETA when this will be merged ? And is it possible to know when next release will be ? Just to know if I need to build terraform locally to have this feature :)

[danawillow]

LGTM, thanks @cblecker! Merging now. @zopanix I'm not sure when the next release will be.

[zopanix]

@danawillow Ok, thx for merging, I'll build terraofrm using master for the moment and will be waiting for next release :) I must say things are moving quickly here. That's always nice to have :)

[cblecker]

Thanks for the review and merge, @danawillow! Appreciated :)

@zopanix -- Minor revisions of Terraform are cut on average every two weeks. Last release was cut a week ago, so maybe another week or so? There are never guarantees, but it won't be long that's for sure.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.