provider/aws: Add support for setting MSSQL Timezone in aws_db_instance

[catsby]

Adds support for setting the Timezone for MSSQL databases in the aws_db_instance resource. Fixes #8937

TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSDBInstance_MSSQL_TZ -timeout 120m
=== RUN   TestAccAWSDBInstance_MSSQL_TZ
--- PASS: TestAccAWSDBInstance_MSSQL_TZ (2045.61s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    2045.692s

[stack72]

LGTM! Thanks @catsby :)

[bmurtagh]

Awesome! Ty @catsby!

[riverofcode]

I just got a release of 0.8.5 and set the "timezone" for a SQL Server SE deployment to "Eastern Standard Time" as such timezone = "Eastern Standard Time" in my tf code but it didn't set the instance.

[catsby]

Hey @riverofcode – can you expand on that some? Did you set the timezone before creating the instance? It's only settable on create, so setting it after should force a destroy and recreate scenario in the next plan.

When you say "didn't set the instance", could you possibly provide an example config that shows this? Here's a config I used this morning to create 3 DBs, demonstrating the timezones. Each created a DB in the timezone I expected (2 are the same, but one is "US Eastern" and the other just "Eastern", for the same results:

• https://gist.github.com/catsby/d1cf21e8e00eaba1adf461a0fddc7c4d

[riverofcode]

Stupidity on my part. Problem resolved. :-(

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.