provider/azurerm: Add support for setting the primary network interface

[kvisscher]

I'm trying to add support for setting the primary network interface for an Azure VM. This works (we deployed something with this change :-)), but I'm not sure how to write a test to proof it to you guys.

Can you guys point me in the right direction?

[pearcec]

I just validated this patch works. Much better approach then anything I had planned on #6514 . Keeps the code from breaking and easy fix. Suggest we need documentation added as well. I am going to fork off your repo and work of your branch. I will try to add some tests and documentation and give you a PR.

[pearcec]

I just pushed and submitted a PR for this PR kvisscher#1 Hopefully @kvisscher is still active on this thread. If not we can just reroll on the latest branch and submit a new PR.

[skinny]

I'll poke @kvisscher (he's normally sitting a couple of meters away from my desk) when he's back from his holiday next week! Thanks for the work!

[kvisscher]

@pearcec I've updated my PR with your changes. Can you verify that this is OK 👍 ?

[pearcec]

Looks good. Did you pull of the latest master? Initially I tried to merge what you had off master and the PR was a bit stale.

[kvisscher]

@pearcec I pulled from master 8 days ago :-). Want me to rebase again?

[pearcec]

You are probably good then. Send out the PR and see what happens.

[kvisscher]

@pearcec I made be mistaken, but this PR is already pending against the hashicorp/terrform master.

[pearcec]

Right I think you are good. Hopefully it gets picked up soon.

[kvisscher]

@radeksimko Don't want to bother you, but is there any chance you know someone in the community who has the super powers to merge this in?

[pmcatominey]

Nice work!

Fixes #6514.

[pmcatominey]

Tests pass!

TF_ACC=1 go test ./builtin/providers/azurerm -v -run TestAccAzureRMVirtualMachine_primary -timeout 120m
=== RUN   TestAccAzureRMVirtualMachine_primaryNetworkInterfaceId
--- PASS: TestAccAzureRMVirtualMachine_primaryNetworkInterfaceId (420.95s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/azurerm	420.962s

@kvisscher if you're happy with the PR could you remove the WIP tag from the title?

[kvisscher]

@pmcatominey Done 😄

[StephenWeatherford]

(wrong PR)

[kblackstone]

what is the syntax to set an interface as primary?

[StephenWeatherford]

@kblackstone https://www.terraform.io/docs/providers/azurerm/r/virtual_machine.html#primary_network_interface_id

[kblackstone]

@StephenWeatherford thank you!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.