Basic authentication for HTTP remote state backend #11301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grubernaut
reviewed
Jan 20, 2017
| } | ||
|
|
||
| // Prepare the request | ||
| if c.Username != "" { |
There was a problem hiding this comment.
What if username is set and password is not set? Possible to add in extra verification for this case?
There was a problem hiding this comment.
Unnecessary. The empty string is the zero value, so in this case the HTTP client will just use an empty password, which is totally legit for HTTP basic auth.
grubernaut
reviewed
Jan 20, 2017
| @@ -141,6 +161,9 @@ func (c *HTTPClient) Put(data []byte) error { | |||
| req.Header.Set("Content-Type", "application/json") | |||
| req.Header.Set("Content-MD5", b64) | |||
| req.ContentLength = int64(len(data)) | |||
| if c.Username != "" { | |||
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple fix to make the HTTP remote state backend pass muster for production use.