Fix: Incorrect AWS Lambda Qualifier Regexp #11383
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change:
What changed? ... and Why:
The regexp is currently set to:
pattern := ^[a-zA-Z0-9$_]+$
The AWS docs state that qualifer names must conform to the following
regexp:
Pattern: (|[a-zA-Z0-9$_-]+)
As you can see, the current regexp in Terraform is missing the
-
atthe end.
This addresses that.
How has it been tested?
Added a few test cases to the existing spec for
AwsLambdaQualifier
validation.