provider/openstack: Remove Default Security Group Rules #11466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the default security group rules that are automatically created when a security group is created. These rules are usually permissive egress rules which makes it difficult to add more strict egress security group rules.
|
Hi @jtopjian Do you think this is backwards incompatible? This will cause a change on everyones infrastructure right? P. |
|
@stack72 It shouldn't. Only the |
|
You are correct :) I didn't pay close enough attention it seems Thanks P. |
stack72
pushed a commit
that referenced
this pull request
Jan 29, 2017
This commit removes the default security group rules that are automatically created when a security group is created. These rules are usually permissive egress rules which makes it difficult to add more strict egress security group rules.
|
No worries at all! I would have rather double-checked than gotten myself into a sticky situation :) |
beyhan
added a commit
to cloudfoundry/bosh-openstack-cpi-release
that referenced
this pull request
Feb 17, 2017
- terraform has changed the default behavior for security group creation. See: hashicorp/terraform#11466 Signed-off-by: Beyhan Veli <beyhan.veli@sap.com> Signed-off-by: Felix Riegger <felix.riegger@sap.com>
beyhan
pushed a commit
to cloudfoundry/bosh-openstack-cpi-release
that referenced
this pull request
Feb 17, 2017
- terraform has changed the default behavior for security group creation. See: hashicorp/terraform#11466 Signed-off-by: Beyhan Veli <beyhan.veli@sap.com>
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the default security group rules that are automatically
created when a security group is created. These rules are usually
permissive egress rules which makes it difficult to add more strict egress
security group rules.
Fixes #9799