Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rancher_stack: Retrieve docker_compose and rancher_compose in Read #11550

Merged
merged 1 commit into from
Jan 31, 2017
Merged

rancher_stack: Retrieve docker_compose and rancher_compose in Read #11550

merged 1 commit into from
Jan 31, 2017

Conversation

raphink
Copy link
Contributor

@raphink raphink commented Jan 31, 2017

Without this, when importing an existing stack into Terraform,
the first Terraform run is non convergent as it needs to retrieve
the existing values.

@mcanevet
Copy link
Contributor

Fixes #11055

Without this, when importing an existing stack into Terraform,
the first Terraform run is non convergent as it needs to retrieve
the existing values.
@stack72
Copy link
Contributor

stack72 commented Jan 31, 2017

LGTM! Thanks :)

@stack72 stack72 merged commit 20c0668 into hashicorp:master Jan 31, 2017
stack72 pushed a commit that referenced this pull request Jan 31, 2017
…11550)

Without this, when importing an existing stack into Terraform,
the first Terraform run is non convergent as it needs to retrieve
the existing values.
@johnrengelman
Copy link
Contributor

@raphink did you test this with importing a stack that was created with a catalog entry?
I ran into issues with that, so I think maybe setting the docker_compose and rancher_compose attributes only when the catalog entry is not set?

arcadiatea pushed a commit to ticketmaster/terraform that referenced this pull request Feb 9, 2017
…ashicorp#11550)

Without this, when importing an existing stack into Terraform,
the first Terraform run is non convergent as it needs to retrieve
the existing values.
@ghost
Copy link

ghost commented Apr 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants