Closes #11567. Handled Rancher deleted resources. #11607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you sir. Will update tests and update this PR shortly. |
johnrengelman
force-pushed
the
rancher-deleted-resources
branch
from
ff58cad to
3ef17af
Compare
|
Updated. |
stack72
reviewed
Feb 1, 2017
| @@ -39,6 +40,50 @@ func TestAccRancherEnvironment(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| func TestAccRancherEnvironment_diappears(t *testing.T) { | |||
There was a problem hiding this comment.
_disappears not _diappers ;)
There was a problem hiding this comment.
fixed and pushed.
johnrengelman
force-pushed
the
rancher-deleted-resources
branch
from
3ef17af to
972eb56
Compare
|
This LGTM! |
stack72
pushed a commit
that referenced
this pull request
Feb 1, 2017
arcadiatea
pushed a commit
to ticketmaster/terraform
that referenced
this pull request
Feb 9, 2017
…#11607) * Fix some spec names. * Closes hashicorp#11567 .Handle deleted/purged resources from Rancher.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @raphink
I wasn't sure how to add a test for this, since I need TF to create a resource, then call the Rancher API directly to delete it, then run TF again and see that the ID changes.
@stack72 if you can point me to a spec that does something like this, I'd be happy to add it.