Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_codecommit_trigger: fix typo that causes serialization to fail when events is non-empty #11839

Merged
merged 1 commit into from
Feb 10, 2017

Conversation

Flygsand
Copy link

@Flygsand Flygsand commented Feb 9, 2017

Debug output (see invalid JSON):

2017/02/09 23:27:40 [DEBUG] plugin: terraform.exe: ---[ REQUEST POST-SIGN ]-----------------------------
2017/02/09 23:27:40 [DEBUG] plugin: terraform.exe: POST / HTTP/1.1
2017/02/09 23:27:40 [DEBUG] plugin: terraform.exe: Host: codecommit.eu-west-1.amazonaws.com
2017/02/09 23:27:40 [DEBUG] plugin: terraform.exe: User-Agent: APN/1.0 HashiCorp/1.0 Terraform/0.8.6
2017/02/09 23:27:40 [DEBUG] plugin: terraform.exe: Content-Length: 236
2017/02/09 23:27:40 [DEBUG] plugin: terraform.exe: Authorization: ...
2017/02/09 23:27:40 [DEBUG] plugin: terraform.exe: Content-Type: application/x-amz-json-1.1
2017/02/09 23:27:40 [DEBUG] plugin: terraform.exe: X-Amz-Date: 20170209T222740Z
2017/02/09 23:27:40 [DEBUG] plugin: terraform.exe: X-Amz-Target: CodeCommit_20150413.PutRepositoryTriggers
2017/02/09 23:27:40 [DEBUG] plugin: terraform.exe: Accept-Encoding: gzip
2017/02/09 23:27:40 [DEBUG] plugin: terraform.exe:
2017/02/09 23:27:40 [DEBUG] plugin: terraform.exe: {"repositoryName":"foo","triggers":[{"branches":[,],"customData":"","destinationArn":"arn:aws:lambda:eu-west-1:...:function:codebuild-hook","events":["updateReference","createReference"],"name":"codebuild-hook"}]}
2017/02/09 23:27:40 [DEBUG] plugin: terraform.exe: -----------------------------------------------------
Error applying plan:

1 error(s) occurred:

* aws_codecommit_trigger.foo2017/02/09 23:27:40 [DEBUG] plugin: C:\HashiCorp\Terraform\bin\terraform.exe: plugin process exited
: Error creating CodeCommit Trigger: SerializationException:
        status code: 400, request id: ...

Terraform does not automatically rollback in the face of errors.
Instead, your Terraform state file has been partially updated with
any resources that successfully completed. Please address the error
above and apply again to incrementally change your infrastructure.

@stack72
Copy link
Contributor

stack72 commented Feb 10, 2017

Nice find :) LGTM! Thanks forthis

@ghost
Copy link

ghost commented Apr 16, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants