provider/aws: Return errors from Elastic Beanstalk

[dharrisio]

In the event that an unexpected state is returned from
environmentStateRefreshFunc, errors in the Elastic Beanstalk console
will now be returned to the user.

As an example the error returned for an issue like #10667 is now

Error applying plan:

1 error(s) occurred:

* aws_elastic_beanstalk_environment.test-eb-staging: 1 error(s) occurred:

* aws_elastic_beanstalk_environment.test-eb-staging: Error waiting for Elastic Beanstalk Environment (e-bhn3m2qfrb) to become ready: 2 error(s) occurred:

* 2017-03-03 18:24:50.158 +0000 UTC (e-bhn3m2qfrb) : Environment must have instance profile associated with it.
* 2017-03-03 18:24:50.256 +0000 UTC (e-bhn3m2qfrb) : Failed to launch environment.

template_change test fails due to not having solution stack in my account. Otherwise everything else passed.

=== RUN   TestAccAWSBeanstalkEnv_basic
--- PASS: TestAccAWSBeanstalkEnv_basic (570.08s)
=== RUN   TestAccAWSBeanstalkEnv_tier
--- PASS: TestAccAWSBeanstalkEnv_tier (689.76s)
=== RUN   TestAccAWSBeanstalkEnv_outputs
--- PASS: TestAccAWSBeanstalkEnv_outputs (532.16s)
=== RUN   TestAccAWSBeanstalkEnv_cname_prefix
--- PASS: TestAccAWSBeanstalkEnv_cname_prefix (603.94s)
=== RUN   TestAccAWSBeanstalkEnv_config
--- PASS: TestAccAWSBeanstalkEnv_config (690.00s)
=== RUN   TestAccAWSBeanstalkEnv_resource
--- PASS: TestAccAWSBeanstalkEnv_resource (562.63s)
=== RUN   TestAccAWSBeanstalkEnv_vpc
--- PASS: TestAccAWSBeanstalkEnv_vpc (547.13s)
=== RUN   TestAccAWSBeanstalkEnv_template_change
--- FAIL: TestAccAWSBeanstalkEnv_template_change (575.32s)
	testing.go:265: Step 0 error: Error applying: 1 error(s) occurred:
		
		* aws_elastic_beanstalk_configuration_template.template: 1 error(s) occurred:
		
		* aws_elastic_beanstalk_configuration_template.template: Error creating Elastic Beanstalk configuration template: InvalidParameterValue: No Solution Stack named '64bit Amazon Linux 2016.03 v2.1.3 running Go 1.5' found.
			status code: 400, request id: 051d8740-0034-11e7-9e87-c915267dea18
=== RUN   TestAccAWSBeanstalkEnv_basic_settings_update
--- PASS: TestAccAWSBeanstalkEnv_basic_settings_update (881.23s)
=== RUN   TestAccAWSBeanstalkEnv_version_label
--- PASS: TestAccAWSBeanstalkEnv_version_label (698.05s)
FAIL
exit status 1
FAIL	github.com/hashicorp/terraform/builtin/providers/aws	6350.316s

@jbardin I also took this opportunity to go through your feedback on #7222 and make the changes suggested there. Let me know if this lines up with what you were suggesting, thanks!

[stack72]

This looks really good - thanks for all the work here @dharrisio :)

Paul

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.