provider/aws: Refresh iam saml provider from state on 404 #12602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
reviewed
Mar 12, 2017
| @@ -70,6 +72,11 @@ func resourceAwsIamSamlProviderRead(d *schema.ResourceData, meta interface{}) er | |||
| } | |||
| out, err := iamconn.GetSAMLProvider(input) | |||
| if err != nil { | |||
| if ec2err, ok := err.(awserr.Error); ok && ec2err.Code() == "NoSuchEntity" { | |||
There was a problem hiding this comment.
it's not exactly EC2 error in this context, but that's really a nitpick 😄
There was a problem hiding this comment.
You are correct - fixed now :) Will merge on green
radeksimko
approved these changes
Mar 12, 2017
Fixes: #12599 Before this patch: ``` % terraform plan Refreshing Terraform state in-memory prior to plan... The refreshed state will be used to calculate this plan, but will not be persisted to local or remote state storage. aws_iam_saml_provider.salesforce: Refreshing state... (ID: arn:aws:i...rce-test) Error refreshing state: 1 error(s) occurred: * aws_iam_saml_provider.salesforce: aws_iam_saml_provider.salesforce: NoSuchEntity: Manifest not found for arn arn:aws:iam::187416307283:saml-provider/tf-salesforce-test status code: 404, request id: fc32c7f8-0631-11e7-8e1f-29a8c10edf64 ``` After this patch: ``` % terraform plan ✚ ✭ [WARN] /Users/stacko/Code/go/bin/terraform-provider-aws overrides an internal plugin for aws-provider. If you did not expect to see this message you will need to remove the old plugin. See https://www.terraform.io/docs/internals/internal-plugins.html Refreshing Terraform state in-memory prior to plan... The refreshed state will be used to calculate this plan, but will not be persisted to local or remote state storage. aws_iam_saml_provider.salesforce: Refreshing state... (ID: arn:aws:i...rce-test) The Terraform execution plan has been generated and is shown below. Resources are shown in alphabetical order for quick scanning. Green resources will be created (or destroyed and then created if an existing resource exists), yellow resources are being changed in-place, and red resources will be destroyed. Cyan entries are data sources to be read. Note: You didn't specify an "-out" parameter to save this plan, so when "apply" is called, Terraform can't guarantee this is what will execute. + aws_iam_saml_provider.salesforce arn: "<computed>" name: "tf-salesforce-test" ```
stack72
force-pushed
the
b-aws-saml-refresh-404
branch
from
0003cb9
to
41ae778
Compare
stack72
added a commit
that referenced
this pull request
Mar 13, 2017
Fixes: #12599 Before this patch: ``` % terraform plan Refreshing Terraform state in-memory prior to plan... The refreshed state will be used to calculate this plan, but will not be persisted to local or remote state storage. aws_iam_saml_provider.salesforce: Refreshing state... (ID: arn:aws:i...rce-test) Error refreshing state: 1 error(s) occurred: * aws_iam_saml_provider.salesforce: aws_iam_saml_provider.salesforce: NoSuchEntity: Manifest not found for arn arn:aws:iam::187416307283:saml-provider/tf-salesforce-test status code: 404, request id: fc32c7f8-0631-11e7-8e1f-29a8c10edf64 ``` After this patch: ``` % terraform plan ✚ ✭ [WARN] /Users/stacko/Code/go/bin/terraform-provider-aws overrides an internal plugin for aws-provider. If you did not expect to see this message you will need to remove the old plugin. See https://www.terraform.io/docs/internals/internal-plugins.html Refreshing Terraform state in-memory prior to plan... The refreshed state will be used to calculate this plan, but will not be persisted to local or remote state storage. aws_iam_saml_provider.salesforce: Refreshing state... (ID: arn:aws:i...rce-test) The Terraform execution plan has been generated and is shown below. Resources are shown in alphabetical order for quick scanning. Green resources will be created (or destroyed and then created if an existing resource exists), yellow resources are being changed in-place, and red resources will be destroyed. Cyan entries are data sources to be read. Note: You didn't specify an "-out" parameter to save this plan, so when "apply" is called, Terraform can't guarantee this is what will execute. + aws_iam_saml_provider.salesforce arn: "<computed>" name: "tf-salesforce-test" ```
yanndegat
pushed a commit
to yanndegat/terraform
that referenced
this pull request
Mar 13, 2017
…12602) Fixes: hashicorp#12599 Before this patch: ``` % terraform plan Refreshing Terraform state in-memory prior to plan... The refreshed state will be used to calculate this plan, but will not be persisted to local or remote state storage. aws_iam_saml_provider.salesforce: Refreshing state... (ID: arn:aws:i...rce-test) Error refreshing state: 1 error(s) occurred: * aws_iam_saml_provider.salesforce: aws_iam_saml_provider.salesforce: NoSuchEntity: Manifest not found for arn arn:aws:iam::187416307283:saml-provider/tf-salesforce-test status code: 404, request id: fc32c7f8-0631-11e7-8e1f-29a8c10edf64 ``` After this patch: ``` % terraform plan ✚ ✭ [WARN] /Users/stacko/Code/go/bin/terraform-provider-aws overrides an internal plugin for aws-provider. If you did not expect to see this message you will need to remove the old plugin. See https://www.terraform.io/docs/internals/internal-plugins.html Refreshing Terraform state in-memory prior to plan... The refreshed state will be used to calculate this plan, but will not be persisted to local or remote state storage. aws_iam_saml_provider.salesforce: Refreshing state... (ID: arn:aws:i...rce-test) The Terraform execution plan has been generated and is shown below. Resources are shown in alphabetical order for quick scanning. Green resources will be created (or destroyed and then created if an existing resource exists), yellow resources are being changed in-place, and red resources will be destroyed. Cyan entries are data sources to be read. Note: You didn't specify an "-out" parameter to save this plan, so when "apply" is called, Terraform can't guarantee this is what will execute. + aws_iam_saml_provider.salesforce arn: "<computed>" name: "tf-salesforce-test" ```
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #12599
Before this patch:
After this patch: