Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/google: drop the account file. #12729

Merged
merged 1 commit into from
Mar 16, 2017
Merged

Conversation

paddycarver
Copy link
Contributor

This was already marked as removed, but the way the provider handled it,
people were still being prompted for input anyways. This removes it from
the provider entirely, so people won't be prompted for input.

This was already marked as removed, but the way the provider handled it,
people were still being prompted for input anyways. This removes it from
the provider entirely, so people won't be prompted for input.
@danawillow
Copy link
Contributor

Alternative: should terraform core change so that people stop getting prompted for removed fields?

(I'm ok with this change but it seems to me that if best practice is to mark the field as removed instead of actually removing it, then we should try to adhere to that if possible)

@paddycarver
Copy link
Contributor Author

(I'm ok with this change but it seems to me that if best practice is to mark the field as removed instead of actually removing it, then we should try to adhere to that if possible)

I'm with you on that, and just opened #12736 to track it. In the meantime, though, I figure it's a good idea to mitigate the user-visible part, as well.

@ghost
Copy link

ghost commented Apr 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants