Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/google: add support for a few more fields in NodeConfig #12743

Merged
merged 4 commits into from
Mar 21, 2017

Conversation

danawillow
Copy link
Contributor

No description provided.

Copy link
Contributor

@paddycarver paddycarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only thing I'd ask is maybe document the new fields?

@danawillow
Copy link
Contributor Author

Done.

@paddycarver
Copy link
Contributor

LGTM, merge at will. :)

@danawillow danawillow merged commit 596f0a2 into hashicorp:master Mar 21, 2017
@danawillow danawillow deleted the gke-nodeconfig branch March 21, 2017 22:24
@ghost
Copy link

ghost commented Apr 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants