Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for EMR AutoScalingRole #12823

Merged

Conversation

jessecollier
Copy link
Contributor

credit to @tolis-sisiaridis for changes

Addresses #11126

Original PR #11033

@stack72
Copy link
Contributor

stack72 commented Mar 18, 2017

LGTM! I will make the documentation change that shows we now accept it

Thanks for the work here

test results incoming - they take about 40 minutes to run

@stack72
Copy link
Contributor

stack72 commented Mar 18, 2017

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSEMRCluster_'                                                           ✭
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/03/18 13:17:01 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSEMRCluster_ -timeout 120m
=== RUN   TestAccAWSEMRCluster_basic
--- PASS: TestAccAWSEMRCluster_basic (564.41s)
=== RUN   TestAccAWSEMRCluster_terminationProtected
--- PASS: TestAccAWSEMRCluster_terminationProtected (841.33s)
=== RUN   TestAccAWSEMRCluster_visibleToAllUsers
--- PASS: TestAccAWSEMRCluster_visibleToAllUsers (705.93s)
=== RUN   TestAccAWSEMRCluster_tags
--- PASS: TestAccAWSEMRCluster_tags (799.24s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	2910.943s

@darrenhaken
Copy link

@stack72 is this actually still open?

@stack72
Copy link
Contributor

stack72 commented Jan 4, 2018

@darrenhaken no idea I am afraid - I am no longer part of this project

@darrenhaken
Copy link

@stack72 yeah I knew you'd left via Twitter 👍

Looks like I'm going to have to go deep on Terraform codebase then!

@darrenhaken
Copy link

darrenhaken commented Jan 5, 2018

There's now a pull request on the AWS provider for this: hashicorp/terraform-provider-aws#2877

@ghost
Copy link

ghost commented Apr 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants