Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/arukas: Increase timeout to 15mins & use standard helper #12849

Merged
merged 1 commit into from
Mar 19, 2017

Conversation

radeksimko
Copy link
Member

A few Arukas tests keep failing, specifically with this output:

=== RUN   TestAccArukasContainer_Import
--- FAIL: TestAccArukasContainer_Import (627.64s)
    testing.go:268: Step 0 error: Error applying: 1 error(s) occurred:
        
        * arukas_container.foobar: 1 error(s) occurred:
        
        * arukas_container.foobar: Timeout: sleepUntilUp
FAIL

Therefore I decided to increase the default timeout from 10 to 15 minutes and also replace the custom waiter logic with standard helper which should also provide us more details when/if this times out again.

Test plan

make testacc TEST=./builtin/providers/arukas TESTARGS='-run=TestAccArukas'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/03/18 14:59:03 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/arukas -v -run=TestAccArukas -timeout 120m
=== RUN   TestAccArukasContainer_Basic
--- PASS: TestAccArukasContainer_Basic (84.99s)
=== RUN   TestAccArukasContainer_Update
--- PASS: TestAccArukasContainer_Update (165.89s)
=== RUN   TestAccArukasContainer_Minimum
--- PASS: TestAccArukasContainer_Minimum (85.09s)
=== RUN   TestAccArukasContainer_Import
--- PASS: TestAccArukasContainer_Import (93.70s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/arukas	429.688s

Copy link
Contributor

@stack72 stack72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@radeksimko radeksimko merged commit 17afcf2 into master Mar 19, 2017
@radeksimko radeksimko deleted the b-arukas-waiter branch March 19, 2017 18:55
@ghost
Copy link

ghost commented Apr 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants