provider/aws: Added Usage Plan Key resource

[Ninir]

Description

This adds the API Gateway usage plan key, based on the following API: https://docs.aws.amazon.com/apigateway/api-reference/link-relation/usageplankey-create/

Related issues

Follow up of #12542
Might resolve other issues too.

Tests

$ make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSAPIGatewayUsagePlanKey_'     
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/03/18 19:30:46 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSAPIGatewayUsagePlanKey_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayUsagePlanKey_importBasic
--- PASS: TestAccAWSAPIGatewayUsagePlanKey_importBasic (25.35s)
=== RUN   TestAccAWSAPIGatewayUsagePlanKey_basic
--- PASS: TestAccAWSAPIGatewayUsagePlanKey_basic (123.42s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	148.800s

TODOs

• Add the API Gateway Usage Plan Key resource
• Add validation
• Add the documentation
• Add test cases
• Add import tests
• Compile & test

[Ninir]

All ok on from my point of view :)

$ make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSAPIGatewayUsagePlanKey_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/03/20 11:22:27 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSAPIGatewayUsagePlanKey_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayUsagePlanKey_importBasic
--- PASS: TestAccAWSAPIGatewayUsagePlanKey_importBasic (34.99s)
=== RUN   TestAccAWSAPIGatewayUsagePlanKey_basic
--- PASS: TestAccAWSAPIGatewayUsagePlanKey_basic (179.37s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	214.389s

[stack72]

Hi @Ninir

The work looks good - I am questioning the import though. The Read func takes 2 parameters - the ImportPassThrough only has support for the Id - how does the import work?

Paul

[Ninir]

@stack72 Hi Paul,

You're 100% right. Due a typo on my side, the import was working for... usage plan, not usage plan keys.
As the import command only takes two parameters as far as I know, i.e. the resource type & resource name, there are no possibilities to handle such import I guess.

Removing that part.

[stack72]

In that case, we look good here! thanks for the work

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSAPIGatewayUsagePlanKey_'       ✭
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/03/20 13:50:03 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSAPIGatewayUsagePlanKey_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayUsagePlanKey_basic
--- PASS: TestAccAWSAPIGatewayUsagePlanKey_basic (155.47s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	155.496s

Paul

[Ninir]

Thanks for the quick review Paul, as always. 👍

[stack72]

you make these thing easy to review @Ninir :) you always use clear PR descriptions and it's usually the questions we need to ask

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.