Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Add support for Lightsail Static IP Attachment #13207

Merged
merged 1 commit into from
Mar 31, 2017

Conversation

radeksimko
Copy link
Member

Test plan

make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSLightsailStaticIpAttachment'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/03/30 15:04:32 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSLightsailStaticIpAttachment -timeout 120m
=== RUN   TestAccAWSLightsailStaticIpAttachment_basic
--- PASS: TestAccAWSLightsailStaticIpAttachment_basic (84.95s)
=== RUN   TestAccAWSLightsailStaticIpAttachment_disappears
--- PASS: TestAccAWSLightsailStaticIpAttachment_disappears (62.38s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	147.366s

Copy link
Contributor

@grubernaut grubernaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@radeksimko radeksimko merged commit 829649f into master Mar 31, 2017
@radeksimko radeksimko deleted the f-lightsail-static-ip-attachment branch March 31, 2017 06:30
@radeksimko radeksimko mentioned this pull request Mar 31, 2017
@ghost
Copy link

ghost commented Apr 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants