Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

command/hook_ui: Increase max length of state IDs #13317

Merged
merged 1 commit into from
Apr 4, 2017
Merged

command/hook_ui: Increase max length of state IDs #13317

merged 1 commit into from
Apr 4, 2017

Conversation

radeksimko
Copy link
Member

Fixes #13292

grubernaut
grubernaut approved these changes Apr 4, 2017
View reviewed changes
Copy link
Contributor

@grubernaut grubernaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@radeksimko radeksimko merged commit fc72a20 into master Apr 4, 2017
@radeksimko radeksimko deleted the f-hook-ui-increase-max-len branch April 4, 2017 14:41
@minamijoyo minamijoyo mentioned this pull request Sep 9, 2018
Closed
minamijoyo added a commit to minamijoyo/terraform that referenced this pull request Sep 9, 2018
@minamijoyo
command/hook_ui: Truncate the ID considering multibyte characters
b0a26da 
Fixes hashicorp#18822

The `tuncatedId` function had been introduced in hashicorp#12261 and increased the
`maxIdLen` to 80 in hashicorp#13317. Since the number of bytes itself seems to be
unimportant, the ID should be truncated to 80 characters, not 80 bytes.
@minamijoyo minamijoyo mentioned this pull request Sep 9, 2018
Merged
minamijoyo added a commit to minamijoyo/terraform that referenced this pull request Dec 13, 2018
@minamijoyo
command/hook_ui: Truncate the ID considering multibyte characters
33e1839 
Fixes hashicorp#18822

The `tuncatedId` function had been introduced in hashicorp#12261 and increased the
`maxIdLen` to 80 in hashicorp#13317. Since the number of bytes itself seems to be
unimportant, the ID should be truncated to 80 characters, not 80 bytes.
@ghost
Copy link

ghost commented Apr 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@grubernaut grubernaut grubernaut approved these changes

Assignees
No one assigned
Labels
bug core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

State ID's truncated on 0.9.0+
2 participants
@radeksimko @grubernaut