Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Add support for iam_openid_connect_provider #13456

Merged
merged 5 commits into from
Apr 8, 2017

Conversation

radeksimko
Copy link
Member

Closes #6137

In the spirit of reducing number of old, stale PRs and to speed things up a bit I took the liberty to make changes to the original PR and resubmitted.

@ryansroberts I hope you don't mind. Your contribution is still included (and still credited to you), with the appropriate modifications.

Feel free to ask about any of the changes.

Test plan

make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSIAMOpenIDConnectProvider_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/04/06 12:14:51 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSIAMOpenIDConnectProvider_ -timeout 120m
=== RUN   TestAccAWSIAMOpenIDConnectProvider_basic
--- PASS: TestAccAWSIAMOpenIDConnectProvider_basic (68.43s)
=== RUN   TestAccAWSIAMOpenIDConnectProvider_importBasic
--- PASS: TestAccAWSIAMOpenIDConnectProvider_importBasic (38.50s)
=== RUN   TestAccAWSIAMOpenIDConnectProvider_disappears
--- PASS: TestAccAWSIAMOpenIDConnectProvider_disappears (54.81s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	161.773s

Copy link
Contributor

@stack72 stack72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work on closing off this old PR :)

@radeksimko radeksimko merged commit 6e2c758 into master Apr 8, 2017
@radeksimko radeksimko deleted the iam_openid branch April 8, 2017 08:56
@ghost
Copy link

ghost commented Apr 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants