Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provisioner/local-exec: Allow passing env vars to commands #13880

Merged
merged 1 commit into from
Mar 5, 2018
Merged

provisioner/local-exec: Allow passing env vars to commands #13880

merged 1 commit into from
Mar 5, 2018

Conversation

cnicolov
Copy link
Contributor

Fixes #13860

@cnicolov cnicolov changed the title Allow passing env vars to local-exec provisioner provisioner/local-exec: Allow passing env vars to local-exec provisioner Apr 23, 2017
@cnicolov cnicolov changed the title provisioner/local-exec: Allow passing env vars to local-exec provisioner provisioner/local-exec: Allow passing env vars to commands Apr 23, 2017
dasch
dasch reviewed Apr 24, 2017
View reviewed changes
website/source/docs/provisioners/local-exec.html.markdown Outdated
@@ -38,3 +52,6 @@ The following arguments are supported:
as a relative path to the current working directory or as an absolute path.
It is evaluated in a shell, and can use environment variables or Terraform
variables.

* `environment` - (Optional) Block of key value pairs reperesing the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: s/reperesing/representing/

@dasch
Copy link
Contributor

dasch commented May 11, 2017

Any update on this?

@dasch
Copy link
Contributor

dasch commented Jul 18, 2017

bump

@cnoffsin
Copy link

Please approve this. This is especially needed when running ansible playbooks you have to specify the path to the roles and you need ansible_roles_path variable set.

@bacoboy bacoboy mentioned this pull request Sep 23, 2017
Closed
@apparentlymart
Copy link
Contributor

Hi all! Sorry for the long silence here. This got lost in the backlog, it seems.

Unfortunately this changeset came into conflict with another that added the interpreter attribute. This change seems fine to me otherwise, so @cnicolov if you are able to rebase this and resolve the conflicts I see no reason not to merge this. If you're not able to do further work here then no worries -- I know we let it sit for a long time -- just let me know and I can resolve the conflicts here myself when I have some moments.

@cnicolov cnicolov force-pushed the local-exec-env branch 2 times, most recently from 7cc0ee5 to 384abc4 Compare September 27, 2017 14:43
@cnicolov
Copy link
Contributor Author

@apparentlymart It's good to go now - just changed the test case a little bit (to match the upstream approach)

@cnicolov
Copy link
Contributor Author

Hi @apparentlymart , I've resolved the conflicts again, this time for the working_dir attribute.

Could you please review and/or merge/close this PR? It's almost one year old 🎂

@apparentlymart apparentlymart merged commit 999f909 into hashicorp:master Mar 5, 2018
@apparentlymart
Copy link
Contributor

Thanks for updating it again, @cnicolov, and sorry for repeatedly losing this off my radar. 😖

@ksista-ahc
Copy link

ksista-ahc commented May 25, 2018 •
edited
Loading

I have the same problem here now. I want to set environment variables and use them in powershell script. Is the feature merged to use now?

@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dasch dasch dasch left review comments

Assignees
No one assigned
Labels
enhancement provisioner/local-exec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: allow defining environment variables for local-exec provisioner
6 participants
@cnicolov @dasch @cnoffsin @apparentlymart @ksista-ahc @tombuildsstuff