provider/aws: Add support for targets to aws_ssm_association #14246

stack72 · 2017-05-05T17:38:47Z

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSSSMAssociation_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/05/05 20:32:43 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSSMAssociation_ -timeout 120m
=== RUN   TestAccAWSSSMAssociation_basic
--- PASS: TestAccAWSSSMAssociation_basic (139.13s)
=== RUN   TestAccAWSSSMAssociation_withTargets
--- PASS: TestAccAWSSSMAssociation_withTargets (33.19s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	172.343s

Fixes: #13975 ``` % make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSSSMAssociation_' ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) 2017/05/05 20:32:43 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSSMAssociation_ -timeout 120m === RUN TestAccAWSSSMAssociation_basic --- PASS: TestAccAWSSSMAssociation_basic (139.13s) === RUN TestAccAWSSSMAssociation_withTargets --- PASS: TestAccAWSSSMAssociation_withTargets (33.19s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws 172.343s ```

liamjbennett · 2017-05-06T14:49:09Z

@stack72 Thanks

grubernaut

LGTM, one minor doc nit

grubernaut · 2017-05-09T14:19:08Z

website/source/docs/providers/aws/r/ssm_association.html.markdown

 * `parameters` - (Optional) Additional parameters to pass to the SSM document.
+* `targets` - (Optional) The targets (either instances or tags). Instances are specified using Key=instanceids,Values=instanceid1,instanceid2. Tags are specified using Key=tag name,Values=tag value.


Add a note that only one item is allowed here?

grubernaut · 2017-05-09T14:19:24Z

builtin/providers/aws/structure.go

@@ -2085,3 +2086,39 @@ func sliceContainsMap(l []interface{}, m map[string]interface{}) (int, bool) {

 	return -1, false
 }
+
+func expandAwsSsmTargets(d *schema.ResourceData) []*ssm.Target {


Thank you for adding these here

grubernaut · 2017-05-09T14:20:30Z

builtin/providers/aws/resource_aws_ssm_association.go


 	return resourceAwsSsmAssociationRead(d, meta)
 }

 func resourceAwsSsmAssociationRead(d *schema.ResourceData, meta interface{}) error {
 	ssmconn := meta.(*AWSClient).ssmconn

-	log.Printf("[DEBUG] Reading SSM Assosciation: %s", d.Id())
+	log.Printf("[DEBUG] Reading SSM Association: %s", d.Id())


nicwise · 2017-05-17T02:36:22Z

@stack72 I'm curious on this - how do you go about going from pre-0.9.5 SSM associations (name+instanceid) to the new ones, short of hand editing the state or deleting them and reassociating

stack72 · 2017-05-18T15:56:40Z

Hi @nicwise

The old ones will still work - if you need to move to the new ones, just change the resource code locally and terraform will destroy and recreate the association

Paul

nicwise · 2017-05-18T20:19:06Z

Odd @stack72 . We didn't change the terraform code at all, just did an apply with 0.9.5, and it was complaining about not having association_id

Ended up using the command line to find the id's and inject them into the state, then push it back.

stack72 · 2017-05-19T10:18:34Z

Hi @nicwise

Please can you drop some configuration here so that I can try to reproduce?

Thanks

Paul

nicwise · 2017-05-24T04:34:12Z

Sorry for the delay. Here's the TF:

resource "aws_ssm_association" "statsd-node_configuration_ssm" {
  name        = "${aws_ssm_document.statsd-node_configuration_ssm.name}"
  instance_id = "${aws_instance.statsd_node.id}"
}

and the state

"aws_ssm_association.statsd-node_configuration_ssm": {
                    "type": "aws_ssm_association",
                    "depends_on": [
                        "aws_instance.statsd_node",
                        "aws_ssm_document.statsd-node_configuration_ssm"
                    ],
                    "primary": {
                        "id": "test_statsd-node_configuration_ssm",
                        "attributes": {
                            "association_id": "fd6xxxxx-xxxx-xxxx-xxxx-xxxxxxxafb5", <--- wasn't here when it was erroring
                            "id": "test_statsd-node_configuration_ssm",
                            "instance_id": "i-040cxxxxxxx96f",
                            "name": "test_statsd-node_configuration_ssm",
                            "parameters.%": "0",
                            "targets.#": "1",
                            "targets.0.key": "InstanceIds",
                            "targets.0.values.#": "1",
                            "targets.0.values.0": "i-04xxxxxxx96f"
                        },
                        "meta": {},
                        "tainted": false
                    },
                    "deposed": [],
                    "provider": ""
                },

this was failing, saying it didn't have an association_id - that line above wasn't in the state at that point.

Sso we looked up the ID using the API, edited the state to include the line above, and 👍

We only had, I think, 9 of these, so it wasn't huge to do by hand.

ghost · 2020-04-12T02:01:43Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

stack72 added enhancement provider/aws labels May 5, 2017

grubernaut approved these changes May 9, 2017

View reviewed changes

Update ssm_association.html.markdown

38db2ae

stack72 merged commit 9dd4e5b into master May 9, 2017

stack72 deleted the f-aws-ssm-association-target-support-13975 branch May 9, 2017 14:49

ghost locked and limited conversation to collaborators Apr 12, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

provider/aws: Add support for targets to aws_ssm_association #14246

provider/aws: Add support for targets to aws_ssm_association #14246

stack72 commented May 5, 2017

liamjbennett commented May 6, 2017

grubernaut left a comment

grubernaut May 9, 2017

grubernaut May 9, 2017

grubernaut May 9, 2017

nicwise commented May 17, 2017

stack72 commented May 18, 2017

nicwise commented May 18, 2017

stack72 commented May 19, 2017

nicwise commented May 24, 2017 •

edited

Loading

ghost commented Apr 12, 2020

		* `parameters` - (Optional) Additional parameters to pass to the SSM document.
		* `targets` - (Optional) The targets (either instances or tags). Instances are specified using Key=instanceids,Values=instanceid1,instanceid2. Tags are specified using Key=tag name,Values=tag value.

provider/aws: Add support for targets to aws_ssm_association #14246

provider/aws: Add support for targets to aws_ssm_association #14246

Conversation

stack72 commented May 5, 2017

liamjbennett commented May 6, 2017

grubernaut left a comment

Choose a reason for hiding this comment

grubernaut May 9, 2017

Choose a reason for hiding this comment

grubernaut May 9, 2017

Choose a reason for hiding this comment

grubernaut May 9, 2017

Choose a reason for hiding this comment

nicwise commented May 17, 2017

stack72 commented May 18, 2017

nicwise commented May 18, 2017

stack72 commented May 19, 2017

nicwise commented May 24, 2017 • edited Loading

ghost commented Apr 12, 2020

nicwise commented May 24, 2017 •

edited

Loading