Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/provider-split: Split out the Oracle OPC provider to new structure #14362

Merged
merged 5 commits into from
May 16, 2017

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented May 10, 2017

To be merged after 0.9.5 release

Copy link
Contributor

@mitchellh mitchellh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as this is in line with what @jbardin is thinking too.

@jbardin
Copy link
Member

jbardin commented May 16, 2017

I like the look of this approach. Though the vendoring is a little awkward during the 0.9 releases, this gives a really good way to transition the providers. 👍

stack72 and others added 5 commits May 16, 2017 19:40
As we march towards Terraform 0.10.0, we are going to start building the
terraform providers as separate binaries - this will allow us to
continually release them. Before we go to 0.10.0, we need to be able to
continue building providers in the same manner, therefore, we have
hardcoded the path of the provider in the generate-plugins.go file

The interim solution will require us to vendor the opc provider and any
child dependencies, but when we get to 0.10.0, we will no longer have to
do this - the core will auto download the plugin binary. The plugin
package will have it's own dependencies vendored as well.
@stack72 stack72 merged commit 055c18e into master May 16, 2017
@stack72 stack72 deleted the external-provider-opc branch May 16, 2017 16:53
@ghost
Copy link

ghost commented Apr 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants