Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make triton machine deletes synchronous. #14368

Merged
merged 1 commit into from
May 11, 2017

Conversation

sean-
Copy link
Contributor

@sean- sean- commented May 10, 2017

It is required for DELETE operations to return a non-nil response:

if res == nil {

I desired, I can include a follow on commit to this PR that updates helper/resource/state.go's comment re: StateRefreshFunc/WaitForState() to note that DELETE-like operations should include a non-nil response. Something akin to:

diff --git a/helper/resource/state.go b/helper/resource/state.go
index 37c586a11..d1c99a963 100644
--- a/helper/resource/state.go
+++ b/helper/resource/state.go
@@ -13,7 +13,8 @@ var refreshGracePeriod = 30 * time.Second
 // It returns three results. `result` is any object that will be returned
 // as the final object after waiting for state change. This allows you to
 // return the final updated object, for example an EC2 instance after refreshing
-// it.
+// it.  The result object must be non-nil even if the case where the target
+// state has been achieved (e.g. DELETE operations).
 //
 // `state` is the latest state of that object. And `err` is any error that
 // may have happened while refreshing the state.

@stack72 stack72 merged commit 67a27b4 into hashicorp:master May 11, 2017
@sean- sean- deleted the f-triton-synchronous-deletes branch May 11, 2017 19:14
@ghost
Copy link

ghost commented Apr 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants