Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

providers/heroku: import heroku_pipeline resource #14486

Merged
merged 1 commit into from
May 15, 2017

Conversation

cmorent
Copy link
Contributor

@cmorent cmorent commented May 15, 2017

Adds support for importing pipelines with the heroku_pipeline resource.

Resolves #14485

@cmorent
Copy link
Contributor Author

cmorent commented May 15, 2017

$ make testacc TEST=./builtin/providers/heroku
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/05/15 11:48:16 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/heroku -v  -timeout 120m
=== RUN   TestAccHerokuApp_importBasic
--- PASS: TestAccHerokuApp_importBasic (7.89s)
=== RUN   TestAccHerokuApp_importOrganization
--- SKIP: TestAccHerokuApp_importOrganization (0.00s)
	import_heroku_app_test.go:41: HEROKU_ORGANIZATION is not set; skipping test.
=== RUN   TestAccHerokuPipeline_importBasic
--- PASS: TestAccHerokuPipeline_importBasic (2.30s)
...

@cmorent cmorent force-pushed the cm-import-heroku-pipeline branch from 48ca646 to ef6309f Compare May 15, 2017 12:21
Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 thanks!

@catsby catsby merged commit 589febd into hashicorp:master May 15, 2017
vanstee pushed a commit to vanstee/terraform that referenced this pull request Sep 28, 2017
@ghost
Copy link

ghost commented Apr 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

heroku_pipeline does not support import
2 participants