Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Support filtering in ASG data source #14501

Merged
merged 1 commit into from
May 18, 2017

Conversation

radeksimko
Copy link
Member

The original intention was to fix the following test failure:

=== RUN   TestAccAWSAutoscalingGroups_basic
--- FAIL: TestAccAWSAutoscalingGroups_basic (77.99s)
    testing.go:280: Step 1 error: Check failed: Check 2/2 error: data.aws_autoscaling_groups.group_list: Attribute 'names.#' expected "3", got "5"
FAIL

Looking up all ASGs in the whole region in an account which may not be used just for tests is a bit naive as things may change all the time (ASGs come and go as people are testing things), so I added filtering which allows us to scope ASGs via tags.

Copy link
Contributor

@grubernaut grubernaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition, LGTM

@radeksimko radeksimko merged commit 740c92f into master May 18, 2017
@radeksimko radeksimko deleted the f-aws-asg-ds-filter branch May 18, 2017 15:40
@ghost
Copy link

ghost commented Apr 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants