core: fix bad Sprintf in backend migration message #14601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
requested changes
May 18, 2017
command/meta_backend.go
Outdated
| "[reset][green]\n\n"+ | ||
| strings.TrimSpace(successBackendLegacyUnset), s.Backend.Type))) | ||
| m.Ui.Output(m.Colorize().Color( | ||
| "[reset][green]\n\n" + strings.TrimSpace(successBackendLegacyUnset))) |
There was a problem hiding this comment.
I think that having s.Backend.Type here for the context would be still helpful. It also means we'll need to change the message (successBackendLegacyUnset). How about something like this?
Terraform has successfully migrated from legacy remote state to your
configured backend (%q).
radeksimko
added
bug
core
waiting-response
Before this, invoking this codepath would print
Terraform has successfully migrated from legacy remote state to your
configured remote state.%!(EXTRA string=s3)
glasser
force-pushed
the
glasser/bad-sprintf
branch
from
f495bf7
to
1a6094f
Compare
|
Thanks @radeksimko ! I've made the change you requested. |
|
Hi @glasser This LGTM thanks for making the changes suggested Paul |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this, invoking this codepath would print