Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark the aws & gcs secrets as sensitive #14634

Merged
merged 1 commit into from
May 18, 2017

Conversation

mtougeron
Copy link
Contributor

This PR marks the aws s3_access_key & s3_secret_key and the gcs secret_key as Sensitive fields.

@catsby
Copy link
Contributor

catsby commented May 18, 2017

I can't imagine why those would be exported or reused, so yeah this makes sense. hopefully I'm not way off the mark there 😄

@catsby catsby merged commit 0e29b74 into hashicorp:master May 18, 2017
@catsby
Copy link
Contributor

catsby commented May 18, 2017

Thanks!

1 similar comment
@mtougeron
Copy link
Contributor Author

Thanks!

@mtougeron mtougeron deleted the fastly-s3-sensitive-config branch May 18, 2017 20:56
@ghost
Copy link

ghost commented Apr 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants