provider/aws: Allow lightsail resources to work in other regions #14685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously lightsail was limited to `us-east-1` only. This restriction has now been lifted to new regions. ``` $ make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSLightsailInstance_euRegion' ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) 2017/05/19 16:40:48 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSLightsailInstance_euRegion -timeout 120m === RUN TestAccAWSLightsailInstance_euRegion --- PASS: TestAccAWSLightsailInstance_euRegion (45.31s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws 45.319s ``` Fixes: #14668
apparentlymart
approved these changes
May 19, 2017
tombuildsstuff
pushed a commit
that referenced
this pull request
Jun 1, 2017
* provider/aws: Update Lightsail supported regions This commit complements (#14621)[#14621] and (#14685)[#14685]. * Revert "provider/aws: Update Lightsail supported regions" This reverts commit 545c3d6. * This commit complements #14621 and #14685. * Link to AWS docs instead of listing regions Instead of explicitly listing supported Lightsail regions in the docs, we now link to the Lightsail docs.
tombuildsstuff
pushed a commit
that referenced
this pull request
Jun 1, 2017
* provider/aws: Update Lightsail supported regions This commit complements (#14621)[#14621] and (#14685)[#14685]. * Revert "provider/aws: Update Lightsail supported regions" This reverts commit 545c3d6. * This commit complements #14621 and #14685. * Link to AWS docs instead of listing regions Instead of explicitly listing supported Lightsail regions in the docs, we now link to the Lightsail docs.
grubernaut
pushed a commit
to hashicorp/terraform-provider-aws
that referenced
this pull request
Jun 9, 2017
* provider/aws: Update Lightsail supported regions This commit complements (#14621)[hashicorp/terraform#14621] and (#14685)[hashicorp/terraform#14685]. * Revert "provider/aws: Update Lightsail supported regions" This reverts commit 545c3d6e6e7a9b665542ecc3b5e4d857faac749b. * This commit complements #14621 and #14685. * Link to AWS docs instead of listing regions Instead of explicitly listing supported Lightsail regions in the docs, we now link to the Lightsail docs.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously lightsail was limited to
us-east-1only. This restriction has now been lifted to new regions.Fixes: #14668