provider/google: enable use of URI as snapshot name when creating a disk

[paddycarver]

Hi

It's possible to create a disk in a Google project A from a snapshot made in project B. But to do this, you need to use URI of the snapshot in project B.

This PR enable this usage.

I tested it :

• I made a snapshot of a disk in project A (named "snapshot-1")
• I used terraform to create a disk in project B, using the snapshot.

resource "google_compute_disk" "default" {
  name  = "test-disk-gbook"
  type  = "pd-ssd"
  zone  = "europe-west1-d"
  snapshot = "https://www.googleapis.com/compute/v1/projects/sk5-formations-thomas-build/global/snapshots/snapshot-1"
}

Thanks.

Thomas

---

This PR was originally #12278, but due to some git shenanigans, that PR became unusable, so it has been moved here. It was originally opened by @tpoindessous, who remains the shepherd and author of it, no matter what GitHub says. :)

[paddycarver]

The code looks good to me. I made minor changes to the naming of the test functions and removed the check for the environment variable that's no longer being used. Tests still pass and changes are stylistic in nature, so merging this now. :) Great work @tpoindessous, thanks so much for contributing this back to Terraform!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.