Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider/openstack: Enable Security Group Updates #14815

Merged
merged 2 commits into from
May 25, 2017
Merged

provider/openstack: Enable Security Group Updates #14815

merged 2 commits into from
May 25, 2017

Conversation

jtopjian
Copy link
Contributor

This commit enables security group names and descriptions to
be updated without causing a recreate.

For #12912

@jtopjian
vendor: Updating Gophercloud for OpenStack Provider
6720e99
@jtopjian
provider/openstack: Enable Security Group Updates
bba1b94 
This commit enables security group names and descriptions to
be updated without causing a recreate.
@jtopjian
Copy link
Contributor Author 

==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/05/24 19:17:53 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/openstack -v -run=TestAccNetworkingV2Port_updateSecurityGroups -timeout 120m
=== RUN   TestAccNetworkingV2Port_updateSecurityGroups
--- PASS: TestAccNetworkingV2Port_updateSecurityGroups (95.69s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/openstack      95.713s

==> Checking that code complies with gofmt requirements...                                      
go generate $(go list ./... | grep -v /terraform/vendor/)                                       
2017/05/24 19:22:08 Generated command/internal_plugin_list.go                                   
TF_ACC=1 go test ./builtin/providers/openstack -v -run=TestAccNetworkingV2SecGroup -timeout 120m
=== RUN   TestAccNetworkingV2SecGroupRule_importBasic                                           
--- PASS: TestAccNetworkingV2SecGroupRule_importBasic (27.62s)                                  
=== RUN   TestAccNetworkingV2SecGroup_importBasic                                               
--- PASS: TestAccNetworkingV2SecGroup_importBasic (17.44s)                                      
=== RUN   TestAccNetworkingV2SecGroupRule_basic                                                 
--- PASS: TestAccNetworkingV2SecGroupRule_basic (27.64s)                                        
=== RUN   TestAccNetworkingV2SecGroupRule_lowerCaseCIDR                                         
--- PASS: TestAccNetworkingV2SecGroupRule_lowerCaseCIDR (25.88s)                                
=== RUN   TestAccNetworkingV2SecGroupRule_timeout                                               
--- PASS: TestAccNetworkingV2SecGroupRule_timeout (26.65s)                                      
=== RUN   TestAccNetworkingV2SecGroupRule_protocols                                             
--- PASS: TestAccNetworkingV2SecGroupRule_protocols (52.67s)                                    
=== RUN   TestAccNetworkingV2SecGroup_basic                                                     
--- PASS: TestAccNetworkingV2SecGroup_basic (21.27s)                                            
=== RUN   TestAccNetworkingV2SecGroup_noDefaultRules                                            
--- PASS: TestAccNetworkingV2SecGroup_noDefaultRules (16.18s)                                   
=== RUN   TestAccNetworkingV2SecGroup_timeout                                                   
--- PASS: TestAccNetworkingV2SecGroup_timeout (15.92s)                                          
PASS                                                                                            
ok      github.com/hashicorp/terraform/builtin/providers/openstack      231.293s

stack72
stack72 approved these changes May 25, 2017
View reviewed changes
Copy link
Contributor

@stack72 stack72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love not having to create things :) LGTM!

@stack72 stack72 merged commit db47721 into hashicorp:master May 25, 2017
@stack72 stack72 mentioned this pull request May 25, 2017
Closed
fredsted pushed a commit to fredsted/terraform-1 that referenced this pull request May 26, 2017
Merge branch 'master' into 9948-aws_alb_target_group_attachment-multi…
2addc06 
…ple-target-ids

* master: (4237 commits)
  website: don't use regexp for sidebar_current in ovh.erb
  website: correct formatting of gitlab doc preambles
  website: when building, run middleman in verbose mode
  website: don't use regex for sidebar_current, in github.erb
  website: fix regex
  release: clean up after v0.9.6
  v0.9.6
  add mutexes to Local, Backup, and InmemState
  add mutexes to remote.State
  call PersistState immediately when cancelling
  have StateHook periodically PersistState
  provider/opc: update opc provider vendor
  Fix typo (tesr -> test) (hashicorp#14825)
  Update CHANGELOG.md
  Update CHANGELOG.md
  provider/openstack: Enable Security Group Updates (hashicorp#14815)
  Fix gitlab documentation (hashicorp#14803)
  Doc fixes for managed disks in VMs (hashicorp#14811)
  Update news section with Google Cloud webinar post-event info (hashicorp#14816)
  provider/openstack: Updating DNS docs
  ...

# Conflicts:
#	builtin/providers/aws/resource_aws_alb_target_group_attachment.go
@ghost
Copy link

ghost commented Apr 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stack72 stack72 stack72 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtopjian @stack72