provider/openstack: Allow numerical protocols in security group rules

[jtopjian]

This commit enables a user to specify protocols in numerical form
when creating security group rules.

Based on the comment here: #14307 (comment)

cc @jaydub

[jtopjian]

==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/05/29 22:09:56 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/openstack -v -run=TestAccNetworkingV2SecGroupRule -timeout 120m
=== RUN   TestAccNetworkingV2SecGroupRule_importBasic
--- PASS: TestAccNetworkingV2SecGroupRule_importBasic (29.60s)
=== RUN   TestAccNetworkingV2SecGroupRule_basic
--- PASS: TestAccNetworkingV2SecGroupRule_basic (27.52s)
=== RUN   TestAccNetworkingV2SecGroupRule_lowerCaseCIDR
--- PASS: TestAccNetworkingV2SecGroupRule_lowerCaseCIDR (26.05s)
=== RUN   TestAccNetworkingV2SecGroupRule_timeout
--- PASS: TestAccNetworkingV2SecGroupRule_timeout (26.45s)
=== RUN   TestAccNetworkingV2SecGroupRule_protocols
--- PASS: TestAccNetworkingV2SecGroupRule_protocols (53.28s)
=== RUN   TestAccNetworkingV2SecGroupRule_numericProtocol
--- PASS: TestAccNetworkingV2SecGroupRule_numericProtocol (25.06s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/openstack      187.975s

[stack72]

LGTM! Merge at will :)

[jtopjian]

Thanks, Paul!

[jaydub]

I look away for a week, and you solve the problem :-D Bravo!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.