Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/datadog: make datadog_user verified a computed attribute #15034

Merged
merged 2 commits into from
Jun 5, 2017

Conversation

phinze
Copy link
Contributor

@phinze phinze commented Jun 2, 2017

It's read-only and generates supurious diffs for verified users.

It's read-only and generates supurious diffs for verified users.
Copy link
Contributor

@stack72 stack72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 small change please :)

Do the docs need updated as well?

@@ -107,7 +108,7 @@ func resourceDatadogUserRead(d *schema.ResourceData, meta interface{}) error {
return err
}

log.Printf("[DEBUG] user: %v", u)
log.Printf("[DEBUG] user: %s", spew.Sdump(u))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the spew.Dump here? Think this is debug work ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only left it in as the #v output is useless - it's just a bunch of memory addresses. Should we remove the entire line?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just removed the entire debug line as it's pretty much useless :) <3 for the fixing of the debug though

@phinze
Copy link
Contributor Author

phinze commented Jun 3, 2017

Do the docs need updated as well?

Docs already say this is an output-only attribute so this is just fixing up the code to agree with them! 🔧

https://www.terraform.io/docs/providers/datadog/r/user.html#verified

@stack72 stack72 merged commit 110eba2 into master Jun 5, 2017
@stack72 stack72 deleted the datadog-verified-computed branch June 5, 2017 09:09
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants