provider/google: Make google_compute_autoscaler use Update instead of Patch.

[rileykarson]

It looks like our vendored code thinks that Patch has "autoscaler" as an optional field, but the documentation suggests that it is required. It probably regressed when we vendored a new copy of the client code around a month ago.

We didn't catch this because the _update test didn't perform an Update - it performed a Destroy followed by a Create instead. This PR updates the tests so that an actual Update is performed.

Patch doesn't make much sense in this context - we pass in an entire copy of the resource, so we should be using Update anyways.

Fixes: #15056
@danawillow

[stack72]

Hi @rileykarson

thanks for this work - this is a great change

% make testacc TEST=./builtin/providers/google TESTARGS='-run=TestAccComputeAutoscaler'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/06/06 15:12:23 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/google -v -run=TestAccComputeAutoscaler -timeout 120m
=== RUN   TestAccComputeAutoscaler_importBasic
--- PASS: TestAccComputeAutoscaler_importBasic (136.75s)
=== RUN   TestAccComputeAutoscaler_basic
--- PASS: TestAccComputeAutoscaler_basic (122.07s)
=== RUN   TestAccComputeAutoscaler_update
--- PASS: TestAccComputeAutoscaler_update (148.29s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/google	407.126s

Paul

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.