Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/azurerm: Adding data source support for Public IP #15110

Merged
merged 8 commits into from
Jun 6, 2017
Merged

provider/azurerm: Adding data source support for Public IP #15110

merged 8 commits into from
Jun 6, 2017

Conversation

abhijeetgaiha
Copy link

@abhijeetgaiha abhijeetgaiha commented Jun 6, 2017

Adding data source support for azurerm_public_ip.
Resolves #15107.

Test output:

root@f75c8264f691:/go/src/github.com/hashicorp/terraform/builtin/providers/azurerm# go test -v -run ^TestAccDataSourceAzureRMPublicIP_basic$
=== RUN   TestAccDataSourceAzureRMPublicIP_basic
--- PASS: TestAccDataSourceAzureRMPublicIP_basic (85.91s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/azurerm        85.915s

@tombuildsstuff tombuildsstuff changed the title Adding data source support for Public IP provider/azurerm: Adding data source support for Public IP Jun 6, 2017
@stack72
Copy link
Contributor

stack72 commented Jun 6, 2017

Hi @abhijeetgaiha

This looks good to me! Thanks for the work here

% make testacc TEST=./builtin/providers/azurerm TESTARGS='-run=TestAccDataSourceAzureRMPublicIP'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/06/06 14:43:54 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/azurerm -v -run=TestAccDataSourceAzureRMPublicIP -timeout 120m
=== RUN   TestAccDataSourceAzureRMPublicIP_basic
--- PASS: TestAccDataSourceAzureRMPublicIP_basic (73.13s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/azurerm	73.148s

Paul

@stack72 stack72 merged commit 1819303 into hashicorp:master Jun 6, 2017
@abhijeetgaiha abhijeetgaiha deleted the public_ip_data_source branch June 6, 2017 11:56
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data source support for Public IP in AzureRM provider
3 participants