Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignore-missing-config flag to import command #15876

Merged
merged 2 commits into from
Sep 18, 2017
Merged

Add ignore-missing-config flag to import command #15876

merged 2 commits into from
Sep 18, 2017

Conversation

jzbruno
Copy link
Contributor

@jzbruno jzbruno commented Aug 22, 2017

This addresses #15875

Some custom tools may depend on the old behavoir of the import command that does not require matching config. To allow backward compatability, the -ignore-missing-config flag has been added.

@apparentlymart
Copy link
Contributor

Hi @jzbruno! Thanks for working on this.

This seems reasonable to me. Nice work!

My only minor feedback is that I think the option should be called -allow-missing-config, since I think that more clearly communicates what this option does: it permits something that would usually be forbidden.

@jzbruno
Copy link
Contributor Author

jzbruno commented Aug 22, 2017

@apparentlymart Sounds good. I will get that updated.

@apparentlymart apparentlymart self-requested a review August 22, 2017 18:35
@apparentlymart
Copy link
Contributor

Sorry for the delay in getting back to you here, @jzbruno!

This looks good to me. Thanks for the docs, tests etc too!

@apparentlymart apparentlymart merged commit 3f2136d into hashicorp:master Sep 18, 2017
@jzbruno
Copy link
Contributor Author

jzbruno commented Sep 18, 2017 via email

@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants