Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vendored go-getter #15891

Merged
merged 1 commit into from
Aug 24, 2017
Merged

Update vendored go-getter #15891

merged 1 commit into from
Aug 24, 2017

Conversation

apparentlymart
Copy link
Contributor

New features of interest in this update:

  • Support for .tar.xz archives for module sources.
  • Git sources will automatically recursively initialize submodules.

This fixes #15889.

Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems legit 👍

@apparentlymart
Copy link
Contributor Author

apparentlymart commented Aug 24, 2017

$ TF_ACC=1 go test -v ./command/e2etest
=== RUN   TestInitProviders
=== RUN   TestPrimarySeparatePlan
=== RUN   TestVersion
--- PASS: TestVersion (0.02s)
--- PASS: TestInitProviders (1.63s)
2017/08/24 11:08:25 [TRACE] Preserving existing state lineage "46037fb4-3b11-4b4a-b251-f18aa2fe4d4d"
2017/08/24 11:08:25 [TRACE] Preserving existing state lineage "46037fb4-3b11-4b4a-b251-f18aa2fe4d4d"
2017/08/24 11:08:25 [TRACE] Preserving existing state lineage "46037fb4-3b11-4b4a-b251-f18aa2fe4d4d"
2017/08/24 11:08:25 [TRACE] Preserving existing state lineage "46037fb4-3b11-4b4a-b251-f18aa2fe4d4d"
--- PASS: TestPrimarySeparatePlan (3.57s)
PASS
ok  	github.com/hashicorp/terraform/command/e2etest	26.014s

(Running this because the TestInitProviders function here exercises the path that uses go-getter to download and install plugins.)

@apparentlymart apparentlymart merged commit 82c817e into master Aug 24, 2017
@apparentlymart apparentlymart deleted the vendor-go-getter branch February 5, 2018 19:18
@ghost
Copy link

ghost commented Apr 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update 'hashicorp/go-getter' - clone git submodules recursively
2 participants