Allow overriding an implicitly used provider #16619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbardin
force-pushed
the
jbardin/implicit-providers
branch
3 times, most recently
from
d1d33f5
to
3fa3547
Compare
It's become apparent that passing in a provider config for an implicitly used provider would be very useful. While the ProviderConfigTransformer efficiently added providers to the graph, the algorithm was reversed from what would be needed to allow overriding implicit providers. Change the ProviderConfigTransformer to fist add all configured provider, even if they are empty stubs. Then run through all providers being passed in from the parent, and replace the provider nodes we created with proxies, and add implicit proxies where none existed. The extra nodes will then be pruned later.
jbardin
force-pushed
the
jbardin/implicit-providers
branch
from
3fa3547
to
105b66e
Compare
apparentlymart
approved these changes
Nov 28, 2017
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow a module to receive a specific provider, even if there is no config block.
Fixes #16612