get errors from winrm commands #17788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vendor/vendor.json
Outdated
| "versionExact": "master" | ||
| }, | ||
| { | ||
| "path": "github.com/packer-community/winrmcp...", |
There was a problem hiding this comment.
This path looks suspicious... was this a govendor fetch typo?
There was a problem hiding this comment.
yes it is, thanks, I though I caught that before committing :/
jbardin
force-pushed
the
jbardin/communicators
branch
from
1931949
to
ae980ec
Compare
communicator/ssh/communicator.go
Outdated
| @@ -536,7 +540,7 @@ func scpUploadFile(dst string, src io.Reader, w io.Writer, r *bufio.Reader, size | |||
| defer os.Remove(tf.Name()) | |||
| defer tf.Close() | |||
|
|
|||
| log.Println("Copying input data into temporary file so we can read the length") | |||
| log.Println("[DBEUG] Copying input data into temporary file so we can read the length") | |||
apparentlymart
approved these changes
Apr 5, 2018
Ensure correct formatting and add a log level to all output.
The error from a remote command is not exported, and only exposed via the Run method. Otherwise the Run method works exactly like the runCommand function being removed.
Match the tested behavior, and that of the ssh implementation, where the communicator automatically connects when starting a command. Remove unused import from legacy dependency handling.
jbardin
force-pushed
the
jbardin/communicators
branch
from
ae980ec
to
dc8c153
Compare
|
Thanks! pushed a fix for that last typo |
This was referenced Apr 26, 2018
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this may not completely solve the open issues around winrm failures, updating winrmcp and getting the remote errors may help troubleshoot the issues.
The main goal here was to return possible errors from winrm commands.
The command error field in not exported, and only returned from the client
Run*methods. Replace ourrunCommandwith the winrm equivalentClient.Run.Update the
winrmcppackage.Update the log format of both communicators.