Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update resource_provisioner.go #18400

Merged
merged 1 commit into from
Jul 6, 2018
Merged

Update resource_provisioner.go #18400

merged 1 commit into from
Jul 6, 2018

Conversation

skylerto
Copy link
Contributor

@skylerto skylerto commented Jul 5, 2018

fix spacing for service url.

resolves #18399

fix spacing for service url.
@skylerto
Copy link
Contributor Author

skylerto commented Jul 6, 2018

@apparentlymart I'm not sure why the CI is failing as this change is literally adding a space. :(

Looks like it's an issue with the library github.com/hashicorp/terraform/vendor/github.com/hashicorp/errwrap

@mildwonkey
Copy link
Contributor

@skylerto Thank you for submitting this pr, and rest assured we know the failure isn't your doing :)

There's a known issue that @apparentlymart is working on (I believe) - #18380. You might want to watch that issue and we'll try again when it's fixed.

@skylerto
Copy link
Contributor Author

skylerto commented Jul 6, 2018

@mildwonkey thanks! I suspect all failing PRs will be blocked until the issue is resolved?

@mildwonkey
Copy link
Contributor

@skylerto since this is a very small and reasonable change, I ran the tests locally. This PR is mildwonkey-ci approved. I will merge this now and it will be released with the next terraform release (sorry to say I do not have an idea of when that might be).

Thank you again for submitting this bugfix!

@mildwonkey mildwonkey self-requested a review July 6, 2018 18:03
@mildwonkey mildwonkey merged commit adf16ca into hashicorp:master Jul 6, 2018
@skylerto
Copy link
Contributor Author

Just to update: made it into release 0.11.8.

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Looks like the habitat provisioner is missing a space
3 participants