change chef linux provisioner to use user:group chown syntax #18533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also, not quite sure how to add an acceptance test for the new behavior or whether that would really make sense in this case, as it only fixes changes the end result on a freebsd machine (while it looks like the tests run on linux) |
|
Would it be possible to merge this PR for 0.11.9 release? thank you. |
|
@Victorion yes, I think this one can be added to 0.11.9 👍 |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chown user.groupappears to work in linux but not documented (at least not in thechownman page). It also simply doesn't work at all in freebsd (at least on my pfsense machine based on freebsd 11). This changes the provisioner to use the more standardchown user:groupsyntax.Please let me know if this introduces some obscure compatibility issue I'm not aware of.