Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend/azurerm: removing the arm_ prefix from keys #19448

Merged
merged 2 commits into from
Nov 26, 2018

Conversation

tombuildsstuff
Copy link
Contributor

This makes the Backend consistent with the AzureRM/Azure Stack Provider such that this is less confusing for users.

Rather than making this a breaking change I've added a compatibility path and removed references to the old names from the docs.

Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -172,3 +205,13 @@ func (b *Backend) configure(ctx context.Context) error {
b.armClient = armClient
return nil
}

func valueFromDeprecatedField(d *schema.ResourceData, key, deprecatedFieldKey string) string {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice idea 👍 🚿

@tombuildsstuff
Copy link
Contributor Author

Tests pass:

screenshot 2018-11-26 at 11 19 30

@tombuildsstuff tombuildsstuff merged commit d580f30 into master Nov 26, 2018
@tombuildsstuff tombuildsstuff deleted the f/backend/azurerm-remove-prefix branch November 26, 2018 10:19
tombuildsstuff added a commit that referenced this pull request Nov 26, 2018
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants