command/format: Fix rendering of unknown elements in set/map/list #20067
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19998
The diff we produce may not be the best (see test cases), but the definition of "best" is kind of subjective here.
AFAIK 0.11 used to render
[a, b, c] -> [a, (unknown), c]
asbut we now render it as
neither of which is not necessarily right or wrong. LCS is however most likely better than simple index-based comparison.